chore(auth-server): minor code cleanup and fixes#19940
Open
sreecharan-desu wants to merge 2 commits intomozilla:mainfrom
Open
chore(auth-server): minor code cleanup and fixes#19940sreecharan-desu wants to merge 2 commits intomozilla:mainfrom
sreecharan-desu wants to merge 2 commits intomozilla:mainfrom
Conversation
Contributor
|
This pull request issue has been marked as stale due to inactivity. It will be closed in a week if it continues to be stale. |
dschom
reviewed
Apr 16, 2026
dschom
reviewed
Apr 16, 2026
dschom
reviewed
Apr 16, 2026
dschom
reviewed
Apr 16, 2026
dschom
reviewed
Apr 16, 2026
dschom
requested changes
Apr 16, 2026
Contributor
dschom
left a comment
dschom
left a comment
There was a problem hiding this comment.
Thanks for these contributions. This PR has grown stale, but you have some nice clean up here. Please see comments and feel free to refile more targeted PRs. We will try to address them in a timely manner this time around.
sreecharan-desu
force-pushed
the
fix/auth-server-cleanups
branch
from
1910ae5 to
3eb0581
Compare
Contributor
Author
|
Thanks for the feedback, @dschom! I've updated the PR to address your requests:
I hope this targeted version is much easier to review. Let me know if you need any further adjustments! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a few targeted cleanups and improvements to the fxa-auth-server package:
SessionTokenmodel to pull its expiry from theauth-serverconfiguration instead of using a hardcoded static value.These changes address the maintainer's feedback regarding targeted PRs and unhardcoding configuration values, while maintaining existing functionality.